Share Shopping List via WhatsApp#7
Open
Karlsson2 wants to merge 2 commits into
Open
Conversation
Owner
|
I recommend that you remove the styles and place a Pico CSS button in a different color below the download button. For now let's keep it simple. |
Contributor
Author
|
I shall update accordingly 😄 wasn't sure if we should style it or not :D |
Contributor
Author
|
Not sure if this was the solution you were looking for in terms of simplicity(?), I wanted to utilise some of the available colors from the larger color scheme but I assume they aren't available in the classless version :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added functionality to share via whatsapp, some custom css to the whatsapp button.
Suggested changes:
Add whatsapp icon instead (fontawesome?) and make the buttons appear next to eachother to make the UI more streamlined and have the buttons take up less space.
Further improvement: Create a whatsapp button component and move the logic and css to that component to keep it cleaner.