Skip to content

docs: explain example sources and fix fullscreen restore failure - #20

Merged
antono2 merged 2 commits into
masterfrom
docs/file-guidance-20261007
Oct 7, 2026
Merged

antono2 merged 2 commits into
masterfrom
docs/file-guidance-20261007

Conversation

@antono3

@antono3 antono3 commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

Add purpose comments to all 30 maintained source/script/header files, extend the source map, and replace obsolete README script names with the V-native commands present at IMGUI_REVISION.

Also preserve normal restore bounds when toggling a maximized window through fullscreen. The Linux compile and portable-package jobs failed the existing shortcut test because the explicit glfw.restore_window call before entering fullscreen races the window manager's state transitions. Enter fullscreen directly while retaining the prior maximized flag; the existing exit path restores maximization. The geometry assertions are unchanged.

Validation:

  • The original CI-built docking binaries reproduced the normal-restore failure locally under Xvfb/Openbox.
  • Eight consecutive unchanged shortcut-suite runs passed against those binaries with a temporary LD_PRELOAD shim suppressing glfwRestoreWindow, isolating the removed call. This diagnostic is not shipped.
  • The modified shortcut source compiles and passes eight cycles in a small GLFW host. That host uses slower key injection to avoid missing polled keys; it is supporting evidence, not a substitute for application CI.
  • Documentation shell syntax, tool/launcher compilation and launcher --help passed earlier; git diff --check passes. Documentation-only changes leave executable lines unchanged except for the deliberate fullscreen fix.

Full application rebuilds, Windows behavior, Android/device tests and packaging await CI. setup.vsh still calls the removed run_demo_windows.ps1 on Windows; the README documents the available upstream run_demo.vsh route. That separate launcher defect remains maintenance follow-up.

@antono3 antono3 changed the title docs: explain example sources and refresh build guidance docs: explain example sources and fix fullscreen restore failure Oct 7, 2026
@antono2
antono2 merged commit 59a4e53 into master Oct 7, 2026
17 checks passed
@antono2
antono2 deleted the docs/file-guidance-20261007 branch October 7, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants