Repository navigation
fix: repair documented Windows guided setup command - #21
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows guided setup called scripts/run_demo_windows.ps1, which is absent at IMGUI_REVISION fa2e194. Call the pinned ImGui repository's shared V runner instead, using its actual --build-only, --demo-directory and --demo-source options. Keep the selected example executable in the existing Windows runtime directory with its DLLs, and replace the README workaround with the supported guided command.
The Windows CI lane now builds glfw_vulkan through setup.vsh --build-only and stages that output, rather than only syntax-checking setup and building every example directly. The other two example builds retain their existing paths.
Validation: inspected the exact pinned upstream script and output location; local setup --help and git diff --check pass. Full Windows setup execution is not available locally and must pass the changed Windows CI lane. No dependency pins changed.