Map C int to i32 for V3-safe Vulkan FD exports - #16
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Map Vulkan registry C
intto Vi32, including pointer parameters and struct fields. V3 uses 64-bitinton 64-bit hosts; its&inthas the wrong ABI for a Cint*output. This affects the Vulkan external-memory, semaphore, and fence FD exports.Add
i32to the generator's base scalar types so&i32output parameters retain the same mutability treatment as&int.Verification
python3 -m py_compile src/vgenerator.pyint,int*, andint**map toi32,&i32, and&&i32;&i32output is not markedmut.antono2/vulkanchange and particle caller update compile and complete Vulkan–OpenCL zero-copy memory and semaphore smoke tests under V 0.5.2 and a locally patched V3 compiler.The generated module change is in a separate
antono2/vulkanPR.