Adapt generator to Vulkan-Docs protected callbacks - #18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vulkan-Docs v1.4.364 started passing an optional per-requirement
protectargument to generated type, enum, group, and command callbacks. The daily update workflow currently stops withTypeError: VOutputGenerator.genType() takes 4 positional arguments but 5 were given.Accept the argument in each override and pass it to struct generation, where protected declarations are already emitted under a guard. Add a required generation-and-formatting matrix for the last compatible tag and the new tag. This PR changes the generator interface only; a separate workflow change will synchronize matching vendored headers when proposing new published bindings.
Verification
vulkan.vandvulkan_video.vsuccessfully against both v1.4.363 and v1.4.364 with Python 3.12 and V 0.5.2 formatting verification.python3 -m py_compile src/vgenerator.py, YAML parse, andgit diff --checkpass.