Skip to content

Adapt generator to Vulkan-Docs protected callbacks - #18

Merged
antono3 merged 1 commit into
masterfrom
fix/vulkan-docs-protect-callbacks
Sep 29, 2026
Merged

antono3 merged 1 commit into
masterfrom
fix/vulkan-docs-protect-callbacks

Conversation

@antono3

@antono3 antono3 commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

Vulkan-Docs v1.4.364 started passing an optional per-requirement protect argument to generated type, enum, group, and command callbacks. The daily update workflow currently stops with TypeError: VOutputGenerator.genType() takes 4 positional arguments but 5 were given.

Accept the argument in each override and pass it to struct generation, where protected declarations are already emitted under a guard. Add a required generation-and-formatting matrix for the last compatible tag and the new tag. This PR changes the generator interface only; a separate workflow change will synchronize matching vendored headers when proposing new published bindings.

Verification

  • Reproduced the TypeError on unmodified generator master against Vulkan-Docs v1.4.364.
  • Generated vulkan.v and vulkan_video.v successfully against both v1.4.363 and v1.4.364 with Python 3.12 and V 0.5.2 formatting verification.
  • python3 -m py_compile src/vgenerator.py, YAML parse, and git diff --check pass.
  • Generated source files were restored after validation; the PR contains only the generator change and CI regression coverage.

@antono3
antono3 merged commit 60695d3 into master Sep 29, 2026
9 checks passed
@antono3
antono3 deleted the fix/vulkan-docs-protect-callbacks branch September 29, 2026 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants