Guard raw Vulkan platform declarations by registry flags - #50
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regenerate the v1.4.363 raw Vulkan binding so platform-specific types, commands, and function-pointer aliases are selected by explicit V flags such as
-d vulkan_xlib. Each flag also enables the matchingVK_USE_PLATFORM_*C header macro. Extension name and spec-version constants remain available without the flag.This fixes V3's unconditional C typedef emission for platform types absent from the active Vulkan headers. The generator change is tracked in antono2/v_vulkan_bindings#15. Nested generated declarations account for most of this PR's formatting diff;
diff -wisolates the semantic changes to platform guards and constant placement.Verification
-d vulkan_xlib.-d vulkan_xlib.The local full V3 C build hit the compiler's 10 GiB memory limit before reaching the C compiler. This is separate from the platform declaration guards and remains visible in the advisory CI lane.
Compatibility
Consumers using raw platform-specific declarations must pass the corresponding
-d vulkan_<platform>flag and install the native headers. The README documents the flags. A version bump and release will be prepared after this PR and the generator PR pass CI.