Simplify typed error tests for V3 - #60
Merged
Merged
Conversation
antono3
force-pushed
the
test/v3-error-narrowing
branch
from
September 23, 2026 18:35
9699858 to
8d4d955
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove redundant
if err is VulkanErrorchecks immediately after assertions of the same type. The assertion already narrowserrfor the following statements, and V3's C generator currently emits an invalid_typread from the concreteVulkanErrorfor the repeated check.This changes only tests and makes the full ergonomic suite runnable under current V3 with the two pending compiler fixes.
Verification
v fmt -verifyandgit diff --checkpass.