Conversation
|
Here the build for windows https://github.com/Toinane/image-optimizer/releases/tag/v1.3.2 |
|
should close #4 |
|
@Toinane Thank you for the work you have done. But I would like to clarify. PR should not contain side changes, such as cosmetic changes or dependency version changes |
|
@antonreshetov I can't remove cosmetic change as you need to show Windows toolbar icons on the window to allow user to reduce and close your app. I see the toolbar on macos is from Electron's parameter in the BrowserWindows, but it don't show anything on Windows. Also I didn't edit anything about version changes, maybe just the yarn install when I did it. I can remove that from PR. |
|
Weird issue @Uranite I didn't have this.. Are you on Win10 ? Have you tested another folder (like on the desktop) or just some files? |
|
@Toinane I indicated your commit cosmetic changes, here you have changed the height of the lines in the list |
Ah sorry, this was linked to the ToolbarVue, I thought that was it |
|
Should be good now @antonreshetov |
Yeah windows 10, I think it might be because I already ran pingo (an image optimizer) before. I just tried taking a bunch of screenshots from minecraft and i ran the image optimizer and its fine |


Hey, just added Windows support (and maybe Linux too)