fix: visual and accessibility fixes from Storybook review#3
Merged
Conversation
Critical fixes:
- Fix primary color CSS variable self-reference (base: #007bff inline)
- DangerZone action button: secondary → danger variant
- DangerZone: add red left-border + tinted background container
- Table: add empty state row ('No data available')
Accessibility fixes:
- Border token darkened (#e0e0e0 → #b0b0b0) for WCAG 1.4.11 compliance
(affects Input, Select, TextArea, Card, Checkbox borders)
- Success color darkened (#28a745 → #1a7a35) for WCAG AA text contrast
- Ghost button: add visible border (stroke color)
59 tests passing, typecheck clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses all critical and needs-improvement items from the automated Storybook review.
Critical fixes
{colors.primary}→var(--colors-primary)→ itself). Inlined#007bff.variant="secondary"tovariant="danger"Accessibility (WCAG)
#e0e0e0→#b0b0b0(~3.5:1 on white). Affects Input, Select, TextArea, Card, Checkbox.#28a745→#1a7a35(~5.7:1 with white text)border: 1px solid strokeNot in this PR (story-level, no component changes needed)
defaultOpen={true}— story config, not component bugduration={Infinity}— sameStorybook deployed to https://kit.outsidetheboxmodel.com for visual verification.