Upgrade rand to v0.9.4#84
Open
fkouteib wants to merge 1 commit into
Open
Conversation
fkouteib
commented
Jun 3, 2026
fkouteib
commented
Contributor
- Upgrade rand to v0.9.4 to agave v4.0 branch
- Update breaking API changes
fkouteib
commented
Jun 3, 2026
| async fn test_create_accounts_half_rpc_succeeds() { | ||
| let seed = 12345; | ||
| let rpc_client = Arc::new(create_mock_rpc_client(&["succeeds", "fails"], seed)); | ||
| let rpc_client = Arc::new(create_mock_rpc_client(&[ "fails", "succeeds"], seed)); |
Contributor
Author
There was a problem hiding this comment.
This seems fragile that the the ordering seems to modulate the test outcome here, for the same seed. Test should probably be reworked to something more deterministic so it doesn't break on rand crate upgrades. It works for now and still gives us the. 50-50 we are after.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.