Skip to content

Parse loadouts response and send sell orders information to marketOrdersIngest topic#143

Open
DERGONokay wants to merge 2 commits intoao-data:masterfrom
DERGONokay:parse-loadouts
Open

Parse loadouts response and send sell orders information to marketOrdersIngest topic#143
DERGONokay wants to merge 2 commits intoao-data:masterfrom
DERGONokay:parse-loadouts

Conversation

@DERGONokay
Copy link
Copy Markdown

Added a new operation to parse and send sell orders retrieved in the Loadouts tab solving the Issue #9

@phendryx
Copy link
Copy Markdown

I have not tested this, but I think this generates a problem on the server side.

Currently, when someone looks for T8_MEAL_STEW, for example, we bucket everything into 5 minute buckets and return the latest bucket. The problem this could cause is, if we only are using 2 market orders to fulfill the loadout, we are now ignoring the other items that might have been refresh 10 minutes ago.

The reason we bucket the data is we have no way to know if a market item was sold, taken down, changed, etc so we assume we only want to see the most recent data.

To be fair, we have the same issue if someone does a random search that returns a bunch of mismatched items (vs looking at pages of the same item to get the true min/max).

Have to think about how to deal with that issue. Unfortunately, that means this PR will sit on hold until I/we/whoever comes up with a workable solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants