Skip to content

feat: added handling for buy and sell auction requests#145

Open
mattias-wiberg wants to merge 1 commit intoao-data:masterfrom
mattias-wiberg:master
Open

feat: added handling for buy and sell auction requests#145
mattias-wiberg wants to merge 1 commit intoao-data:masterfrom
mattias-wiberg:master

Conversation

@mattias-wiberg
Copy link
Copy Markdown

There are still some questions to be discussed about this PR:

  • Should we use different ingest topics for these?
  • Naming convention feels a little messy what should we call these type of auction actions?
  • I noticed that the requests are sent twice. Should these be cached in a map and then instead sent to the ingest on the respective response? Note that we would have to guess that the response is for the respective request since nothing but the type is included in the response to identify them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant