Open
Conversation
NOTE: This arbiter always grant access on one port, even when there are no requests. oh_fifo_cdc deasserts its access_out when wait_in is high. Signed-off-by: Ola Jeppsson <ola@adapteva.com>
All tests in elink/dv/tests produces the same output as before, except for 'test_regs.emf' where the original code shows a Write-After-Read condition with the access to ERX_CFG. Tested for several hours on one board with epiphany-examples running in parallel with e-read and e-write (to bogus MMR address), no issues. I'm not 100% happy with this one, as far as I can understand the 'oh_fifo_cdc' code there's a chicken-egg problem between 'wait_in'/'access_out' when using 'access_out' as an input to an arbiter request line. I think it would be better if the FIFO also exported 'valid' (~empty). Now the arbiter must guess (round-robin) which port might have data (see note in oh_arbiter_rr3.v). Signed-off-by: Ola Jeppsson <ola@adapteva.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All tests in elink/dv/tests produces the same output as before, except
for 'test_regs.emf' where the original code shows a Write-After-Read
condition with the access to ERX_CFG.
Tested for several hours on one board with
epiphany-examples running in parallel with e-read and e-write (to bogus
MMR address), no issues.
I'm not 100% happy with this one, as far as I can understand the
'oh_fifo_cdc' code there's a chicken-egg problem between
'wait_in'/'access_out' when using 'access_out' as an input to an
arbiter request line. I think it would be better if the FIFO also
exported 'valid' (~empty). Now the arbiter must guess (round-robin)
which port might have data (see note in oh_arbiter_rr3.v).