Add confirmation popups on destructive actions#966
Merged
aome510 merged 5 commits intoaome510:masterfrom Apr 10, 2026
Merged
Conversation
aome510
reviewed
Apr 7, 2026
| track.id, | ||
| ))?; | ||
| ui.popup = Some(PopupState::ConfirmAction { | ||
| message: "Are you sure?".to_string(), |
Owner
There was a problem hiding this comment.
message should be specific. For example, one may try to delete a track but they might accidentally trigger unfollowing artist
Contributor
Author
There was a problem hiding this comment.
check now, changed to more detailed like "Delete this playlist?"
Owner
There was a problem hiding this comment.
is it possible to include the name to be even more specific? Like Remove "track" from this playlist, Unfollow "artist", Unlike "track", etc
aome510
approved these changes
Apr 10, 2026
aome510
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #960
Now on every destructive action in app we show popup with y/n, following / unfollowing and like / unlike track is not considered as a destructive actions. Screenshot: