Migration to ratatui_image instead of viuer#969
Open
sakashimaa wants to merge 3 commits intoaome510:masterfrom
Open
Migration to ratatui_image instead of viuer#969sakashimaa wants to merge 3 commits intoaome510:masterfrom
sakashimaa wants to merge 3 commits intoaome510:masterfrom
Conversation
Owner
|
can you also look into updating the documents (README.md, config.md) to ensure they are up-to-date? |
Contributor
Author
|
yeah i`ll watch iterm2 and docs |
Contributor
Author
Owner
|
I tested it on ghostty + tmux on macos with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Resolves #963
Screenshot:

Summary
viuerwithratatui-imagefor rendering cover imagesset_skip/clear_areahacks —ratatui-imagerenders as a native ratatui widgetviuerinitialization inmain.rs, usePicker::from_query_stdio()for protocol auto-detectioncover_img_scaleusage (no longer needed — scaling is handled byratatui-image)Notes
Picker::from_query_stdio()must run afterenable_raw_mode()but beforeEnterAlternateScreenfor correct protocol detection.In nested terminals (e.g. neovim floating terminal), stdio queries don't reach the actual terminal emulator, so the protocol falls back to Halfblocks. This is a known limitation of
ratatui-image's detection approach. Regular terminals (foot, kitty, iTerm2, etc.) work correctly