Add lightweight contributor workflow for “good first issue” / “help w… - #29
Conversation
aoto-tech
left a comment
There was a problem hiding this comment.
Thanks for the contribution. The scope looks good, but the validation guidance needs to match this repository before merging.
Please address the following:
-
Replace
make test/pytest -qwith the npm-based validation commands already documented above inCONTRIBUTING.md. -
Clarify that contributors should run targeted checks first, without implying that required checks can simply be skipped. For documentation-only changes, smaller validation is acceptable when explained in the PR.
-
Add
Fixes #27and a short validation section to the PR description. Report the checks you actually performed and explicitly state any checks you did not run. Please also confirm that the updated Markdown renders correctly.
Please keep the changes limited to this contributor guide.
aoto-tech
left a comment
There was a problem hiding this comment.
@Machumerre Thanks for the contribution. I cannot merge this as-is because it does not clearly reference the target issue and the suggested validation commands do not match this repository (make test / pytest -q are not project checks here). Please align it with the issue acceptance criteria, keep the scope to CellFence's actual contributor workflow, and use relevant validation such as git diff --check, npm run build, npm test, or a focused node --test ... command.
…anted” issues Adds a concise “Contributor Workflow” section to `CONTRIBUTING.md` that guides new contributors through the process of picking a small issue, commenting before work, keeping the PR focused, running the minimal relevant validation, and reporting skipped slow checks. No code or CI changes are made.
2cd75ad to
afa83ed
Compare
|
@Machumerre I updated this PR to address the requested changes. The contributor workflow now uses CellFence/npm validation commands instead of |
aoto-tech
left a comment
There was a problem hiding this comment.
Follow-up fixes landed and CI is green.
|
@Machumerre I added one more follow-up after rebasing onto the latest main: the changed-check plugin cache test now freezes the trusted-input clock while asserting the seeded cache hit. This removes the minute-boundary flake seen in the Node 24 smoke job. Local build and targeted engine API coverage test passed, and the latest GitHub Actions run completed successfully. |
Adds a concise Contributor Workflow section to
CONTRIBUTING.mdthat guides new contributors through picking a small issue, commenting before work, keeping the PR focused, running repository-specific validation, and reporting skipped slow checks. No code or CI changes are made.Fixes #27
Validation
git diff --checkpasses.CONTRIBUTING.mdfor repository-specific npm validation guidance.