fix(engine): ignore FROM in SQL string literals and comments (#77) - #79
Merged
aoto-tech merged 2 commits intoSep 9, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #77.
Prevents
sqlTableAccessesfrom treatingFROM,JOIN, or other SQL table query verbs found inside single-quoted SQL string literals or SQL comments (/* ... */and-- ...) as real table references.Changes
stripSqlCommentsAndLiteralsinpackages/engine/src/resource-access.tsto sanitize block comments, line comments, and single-quoted string literals while keeping double-quoted identifiers intact.sqlTableAccessesbefore applying the SQL clause regex.tests/resource-access-coverage.test.mjsverifying that SQL string literals (SELECT 'FROM ghost_table' AS label), block comments (SELECT 1 /* FROM ghost_table */), and line comments (SELECT 1 -- FROM ghost_table) do not generate false table references, while real table references continue to match accurately.Validation
npm run buildnode --test tests/resource-access-coverage.test.mjs(42/42 tests pass)