fix(trace): exclude non-HTTP URL schemes like data: URLs from HTTP accesses - #80
Open
Cid-oe wants to merge 1 commit into
Open
fix(trace): exclude non-HTTP URL schemes like data: URLs from HTTP accesses#80Cid-oe wants to merge 1 commit into
Cid-oe wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #74
Summary
When
globalThis.fetchis invoked with non-HTTP(S) schemes such asdata:URLs (e.g.,fetch("data:text/plain,hello")), the response body is resolved locally without performing an HTTP network request. Previously,fetchSelectortreated any valid string/URL as an HTTP target, causing local data processing to be recorded as an HTTP resource access (kind: "http", access: "call").Changes
fetchSelectorinpackages/trace/src/index.tsto validate that the URL protocol ishttp:orhttps:.tests/trace.test.mjsverifying thatfetchcalls with non-HTTP schemes (such asdata:text/plainanddata:application/json) are excluded from HTTP evidence while valid HTTP/HTTPS requests continue to be captured.