fix(engine): include async, type annotations, and class methods in Python public surface hashes (#76) - #82
Open
Cid-oe wants to merge 1 commit into
Open
Conversation
…thon public surface hashes (aoto-tech#76) - Format Python argument type annotations and function return types in surface parts - Prefix async functions with py:async_function: - Extract public class methods and async methods into py:class_member parts - Support surface_part_name resolution for py:async_function: and py:class_member: - Add comprehensive regression test suite for bug aoto-tech#76
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #76 by ensuring Python public API surface serialization preserves async vs sync distinctions, argument type annotations, return types, and class method signatures.
Changes
:type) alongside default values infunction_signature.py:async_function:prefix (and included return annotations:return_type).__init__) in class surface representations aspy:class_member:<class>.<method|async_method>:<name>(<signature>):<returns>.surface_part_nameto resolve top-level names forpy:async_function:andpy:class_member:.tests/module-resolution.test.mjsand added regression test for bug bug: [P2] Python public API surface hashes ignore async, type annotation, and method changes #76 intests/review-regressions.test.mjs.Closes #76