-
Notifications
You must be signed in to change notification settings - Fork 141
Create Service Layer for Airavata #577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yasithdev
wants to merge
26
commits into
master
Choose a base branch
from
service-layer
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahirujayathilake
requested changes
Nov 20, 2025
Member
lahirujayathilake
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yasithdev, I have added some comments
airavata-api/src/main/java/org/apache/airavata/api/server/handler/AiravataServerHandler.java
Outdated
Show resolved
Hide resolved
airavata-api/src/main/java/org/apache/airavata/api/server/handler/AiravataServerHandler.java
Outdated
Show resolved
Hide resolved
airavata-api/src/main/java/org/apache/airavata/api/server/handler/AiravataServerHandler.java
Outdated
Show resolved
Hide resolved
airavata-api/src/main/java/org/apache/airavata/api/server/handler/AiravataServerHandler.java
Outdated
Show resolved
Hide resolved
airavata-api/src/main/java/org/apache/airavata/api/server/handler/AiravataServerHandler.java
Outdated
Show resolved
Hide resolved
airavata-api/src/main/java/org/apache/airavata/service/AiravataService.java
Outdated
Show resolved
Hide resolved
airavata-api/src/main/java/org/apache/airavata/service/OrchestratorService.java
Outdated
Show resolved
Hide resolved
airavata-api/src/main/java/org/apache/airavata/service/OrchestratorService.java
Outdated
Show resolved
Hide resolved
airavata-api/src/main/java/org/apache/airavata/service/RegistryService.java
Outdated
Show resolved
Hide resolved
airavata-api/src/main/java/org/apache/airavata/service/RegistryService.java
Outdated
Show resolved
Hide resolved
0c3a8bd to
e893ac3
Compare
Contributor
Author
|
@lahirujayathilake thanks! I made most of the changes suggested. things missing are:
|
…storages are different (#574) * Making experiment data path relative when the destination and source storage are different. * Storage directory size fetching api (#575) * Making experiment data path relative when the destination and source storage are different. * Enabling storage directory size listing api * Adding storage directory size listing api to python sdk * bump up the sdk version and spotless apply
) Bumps [io.github.ascopes:protobuf-maven-plugin](https://github.com/ascopes/protobuf-maven-plugin) from 2.12.1 to 3.10.2. - [Release notes](https://github.com/ascopes/protobuf-maven-plugin/releases) - [Commits](ascopes/protobuf-maven-plugin@v2.12.1...v3.10.2) --- updated-dependencies: - dependency-name: io.github.ascopes:protobuf-maven-plugin dependency-version: 3.10.2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [io.github.ascopes:protobuf-maven-plugin](https://github.com/ascopes/protobuf-maven-plugin) from 2.12.1 to 3.10.2. - [Release notes](https://github.com/ascopes/protobuf-maven-plugin/releases) - [Commits](ascopes/protobuf-maven-plugin@v2.12.1...v3.10.2) --- updated-dependencies: - dependency-name: io.github.ascopes:protobuf-maven-plugin dependency-version: 3.10.2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…vices that didnt have exception clause
… partially fixed the thrift handlers
f6ef980 to
a071897
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Enhancement to code, styling, CI/CD, or distribution.
java
Pull requests that update Java code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the core airavata logic is implemented in the thrift handlers, which makes it difficult to add new APIs, like Spring HTTP handlers, without going through the thrift handlers. This PR creates a separate service layer to capture all airavata functionalities, and the thrift handlers directly invoke them.