Repository navigation
Conversation
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
2 open findings
What changed in this PR
Corrects the limit-count plugin documentation to accurately describe when the delayed-sync snapshot is refreshed, clarifying timing around synchronization vs. window expiration in both English and Chinese docs.
Changes:
- Update English docs to state the snapshot is replaced on each periodic synchronization, and also refreshed on window expiry.
- Update Chinese docs with the same corrected explanation.
| File | Description |
|---|---|
| docs/en/latest/plugins/limit-count.md | Fixes the delayed-sync snapshot refresh explanation (English). |
| docs/zh/latest/plugins/limit-count.md | Mirrors the same corrected explanation (Chinese). |
🧠 Review effort: Lite
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
Copilot stopped reviewing on behalf of
nic-6443 due to an error
October 8, 2026 11:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
$rate_limiting_infosection added in #13996 says the delayed-sync snapshot is only refreshed after its window has ended. That's wrong.sync_keyreplaces it throughsync_to_shmon every periodic synchronization, which runs withinsync_intervalafter a request (since #14015 also when there is no local delta), and the snapshot is refreshed again when it expires at the end of its window.This corrects the sentence in en and zh. What it was explaining still holds: a request that arrives after a window boundary but before the next synchronization is still checked against the previous snapshot, so its
evaluated_at_mscan briefly be later thancurrent_window.end_ms.