Skip to content

chore: Fix flatcc linking for non-bundled case#894

Open
paleolimbot wants to merge 1 commit into
apache:mainfrom
paleolimbot:ipc-vcpkg-fix
Open

chore: Fix flatcc linking for non-bundled case#894
paleolimbot wants to merge 1 commit into
apache:mainfrom
paleolimbot:ipc-vcpkg-fix

Conversation

@paleolimbot

Copy link
Copy Markdown
Member

It looks as though nanoarrow's IPC feature was added upstream in vcpkg before I could get there; however, required a patch in the flatcc linking (and an update to flatcc, which was also done).

This PR applies the patch with some input from Opus 4.5 that will hopefully help the process (and help get the IPC feature build for homebrew as well).

Closes #796

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.59%. Comparing base (f11d517) to head (dc9cd56).
⚠️ Report is 54 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #894      +/-   ##
==========================================
- Coverage   79.96%   78.59%   -1.38%     
==========================================
  Files         105      106       +1     
  Lines       15461    16128     +667     
  Branches     1738     1858     +120     
==========================================
+ Hits        12364    12675     +311     
- Misses       1998     2286     +288     
- Partials     1099     1167      +68     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@paleolimbot paleolimbot marked this pull request as ready for review June 15, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vcpkg does not include IPC feature

2 participants