Skip to content

feat: Use reference counted arrays when decoding batches that contain dictionaries #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
paleolimbot wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: Use reference counted arrays when decoding batches that contain dictionaries #895

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions src/nanoarrow/ipc/decoder.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,11 @@ static ArrowErrorCode ArrowIpcDictionaryReplace(struct ArrowIpcDictionary* dicti
ArrowArrayRelease(&dictionary->current_value);
}

ArrowArrayMove(value, &dictionary->current_value);
// Convert to a shared array so that clones can reference the same data
// without copying
struct ArrowArray shared;
NANOARROW_RETURN_NOT_OK(ArrowArrayMoveShared(value, &shared));
ArrowArrayMove(&shared, &dictionary->current_value);
return NANOARROW_OK;
}

Expand Down Expand Up @@ -2318,9 +2322,8 @@ static int ArrowIpcDecoderWalkGetArray(struct ArrowArrayView* array_view,
}

if (array_view->dictionary != NULL) {
// TODO: this currently copies the array for every output.
NANOARROW_RETURN_NOT_OK(ArrowIpcDecoderWalkGetArray(
array_view->dictionary, array->dictionary, out->dictionary, error));
// Move the pre-cloned shared dictionary to output (avoids copying)
ArrowArrayMove(array->dictionary, out->dictionary);
}

return NANOARROW_OK;
Expand Down Expand Up @@ -2359,6 +2362,15 @@ static int ArrowIpcDecoderWalkSetArrayView(struct ArrowIpcDecoder* decoder,
// decode.
NANOARROW_RETURN_NOT_OK(
ArrowArrayViewSetArray(array_view->dictionary, dictionary, error));

// Clone the shared dictionary for output (avoids copying dictionary data)
if (array->dictionary != NULL) {
if (array->dictionary->release != NULL) {
ArrowArrayRelease(array->dictionary);
}
NANOARROW_RETURN_NOT_OK(
ArrowArrayCloneShared((struct ArrowArray*)dictionary, array->dictionary));
}
}

ns(FieldNode_struct_t) field =
Expand Down
Loading