Skip to content

[CI] Use environment variables instead of template expressions in workflow run blocks #49725

Closed

Description

@thisisnic

Describe the enhancement

Several workflow files use ${{ }} template expressions directly inside run: blocks. These should be refactored to pass values through environment variables instead, which is the recommended best practice for GitHub Actions workflows.

Example

Before:

- run: |
    if [ "${{ inputs.upload }}" = true ]

After:

- run: |
    if [ "${UPLOAD}" = true ]
  env:
    UPLOAD: ${{ inputs.upload }}

Affected files

  • .github/actions/sync-nightlies/action.yml (inputs.upload)
  • .github/workflows/check_labels.yml (inputs.parent-workflow)
  • .github/workflows/comment_bot.yml (github.event_path)
  • .github/workflows/cpp_windows.yml (inputs.arch, steps.setup-msys2.outputs.msys2-location)
  • .github/workflows/integration.yml (github.event.repository.default_branch)
  • .github/workflows/report_ci.yml

Component(s)

Continuous Integration

Activity

  1. added a commit that references this issue on Apr 15, 2026
  2. added this to the 25.0.0 milestone on Apr 15, 2026
  3. kou commented on Apr 15, 2026

    @kou
    Member

    Issue resolved by pull request 49733
    #49733

  4. added a commit that references this issue on May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions