Skip to content

[C++] Support duration type in floor_temporal/etc #50395

Closed

Description

@rok

Describe the enhancement requested

The temporal rounding kernels round_temporal, floor_temporal, and ceil_temporal are currently only registered for date32/64, time32/64, and timestamp inputs (WithDates, WithTimes, WithTimestamps in scalar_temporal_unary.cc).

It would be useful to round duration inputs to multiples of physical and perhaps some calendar units.

Component(s)

C++

Activity

  1. snigdhachoppac commented on Jul 28, 2026

    @snigdhachoppac
    Contributor

    Hi, I’d like to work on this issue. Would it be acceptable to start by adding DurationType support for physical units to round_temporal, floor_temporal, and ceil_temporal, along with focused C++ tests, while leaving calendar-unit semantics out unless they are specifically desired?

  2. rok commented on Jul 28, 2026

    @rok
    MemberAuthor

    Hey @snigdhachoppac. For calendar units only day and week are non-ambiguous enough to make sense to add them. Please go ahead and open the PR. Once you do ping me and I'll assign you this issue.

  3. added a commit that references this issue on Jul 28, 2026
  4. snigdhachoppac commented on Jul 28, 2026

    @snigdhachoppac
    Contributor

    Thanks, @rok I’ve opened PR implementing duration support for physical units, including day and week, while leaving month, quarter, and year unsupported.

  5. added 2 commits that reference this issue on Jul 28, 2026
  6. added a commit that references this issue on Jul 31, 2026
  7. added this to the 26.0.0 milestone on Jul 31, 2026
  8. rok commented on Jul 31, 2026

    @rok
    MemberAuthor

    Issue resolved by pull request 50675
    #50675

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions