Repository navigation
[C++] Accept Scalar Types Consistently in RunEndEncodedBuilder::AppendScalar and RunEndEncodedBuilder::AppendScalars #50508
Description
Describe the enhancement requested
While RunEndEncodedBuilder::AppendScalar accepts the following API usage:
builder.AppendScalar(**MakeScalar(float32(), 0), 3);
// Or
builder.AppendScalar(**MakeScalar(ree_type, *MakeScalar(float32(), 0)), 2);RunEndEncodedBuilder::AppendScalars, however, only accepts the following style:
builder.AppendScalars({
*MakeScalar(ree_type, *MakeScalar(float32(), 0)),
*MakeScalar(ree_type, *MakeScalar(float32(), 0))
});Component(s)
C++
Activity
Moemenmohamed24 commentedon Jul 14, 2026
Hi @andishgar , I'm working on this enhancement. I'll submit a PR once I have a solution ready.
andishgar commentedon Jul 14, 2026
@Moemenmohamed24, thanks for your contribution! However, you must wait for verification of my issue from an Arrow core developer. I will mention two of them, and if one of them verifies it, you can then proceed to send the PR.
andishgar commentedon Jul 14, 2026
@kou, @pitrou, could you verify this issue?
Moemenmohamed24 commentedon Jul 14, 2026
@andishgar Alright, I’ve read the contribution guidelines for Arrow; I need to post a "take" comment on the issue. I’ll wait for one of the developers to respond. Thanks a lot.
kou commentedon Jul 15, 2026
This issue says that we should accept the following style too, right?
builder.AppendScalars({ *MakeScalar(float32(), 0), *MakeScalar(float32(), 0) });andishgar commentedon Jul 15, 2026
@kou, yes, I mean exactly the API style you mentioned—is it acceptable?
kou commentedon Jul 16, 2026
Yes. Let's work on this.
Moemenmohamed24 commentedon Jul 17, 2026
@kou , @andishgar . Thanks for the verification, I will start working on this now and submit a PR once it's ready.
apacheGH-50508: Clean up comments
apacheGH-50508: Apply clang-format
apacheGH-50508: Address review comments
apacheGH-50508: Address review comments
GH-50508: [C++] Support scalar values in AppendScalars (#50584)
pitrou commentedon Jul 27, 2026
Issue resolved by pull request 50584
#50584