Skip to content

[CI][Dev] Fix shellcheck errors in the ci/scripts/r_sanitize.sh #50773

Closed

Description

@hiroyuki-sato

Describe the enhancement requested

This is the sub issue #44748.

  • SC2155: Declare and assign separately to avoid masking return values.
  • SC2086: Double quote to prevent globbing and word splitting.
  • SC2223: This default assignment may cause DoS due to globbing. Quote it.
shellcheck ci/scripts/r_sanitize.sh

In ci/scripts/r_sanitize.sh line 21:
: ${R_BIN:=RDsan}
  ^-------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/r_sanitize.sh line 26:
pushd ${source_dir}
      ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
pushd "${source_dir}"


In ci/scripts/r_sanitize.sh line 36:
echo "MAKEFLAGS=-j${ncores}" >> ${rhome}/etc/Renviron.site
                                ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
echo "MAKEFLAGS=-j${ncores}" >> "${rhome}"/etc/Renviron.site


In ci/scripts/r_sanitize.sh line 50:
export SUPPRESSION_FILE=$(readlink -f "tools/ubsan.supp")
       ^--------------^ SC2155 (warning): Declare and assign separately to avoid masking return values.

For more information:
  https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2223 -- This default assignment may cause...

Component(s)

Continuous Integration

Activity

  1. added 2 commits that reference this issue on Aug 3, 2026
  2. added a commit that references this issue on Aug 3, 2026
  3. KHARSHAVARDHAN-eng commented on Aug 3, 2026

    @KHARSHAVARDHAN-eng

    @hiroyuki-sato , can i work on this issue.. if this issue is free ??

  4. added a commit that references this issue on Aug 3, 2026
  5. added this to the 26.0.0 milestone on Aug 3, 2026
  6. kou commented on Aug 3, 2026

    @kou
    Member

    Issue resolved by pull request 50775
    #50775

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions