Repository navigation
GH-46137: [C++] Replace grpc-cpp conda package with libgrpc - #47606
Conversation
|
|
6a81372 to
1b03f5b
Compare
| libprotobuf | ||
| libutf8proc | ||
| lz4-c | ||
| make | ||
| meson | ||
| ninja | ||
| nodejs | ||
| orc | ||
| orc<2.1.0 |
There was a problem hiding this comment.
In CI orc is pinned to 1.9.0. This new pin is required due to some upstream bugs with the CMake configuration - see apache/orc#2408
|
The Go failure seems related although I'm not sure I can see anything in the logs that points to the issue. Maybe @zeroshade has an idea? https://github.com/apache/arrow/actions/runs/17863409077/job/50799734977?pr=47606#step:13:1204 |
Indeed the package was renamed (similar to the conda package for arrow going from |
1b03f5b to
7308d5d
Compare
7308d5d to
27db46e
Compare
|
OK this is all green - @kou any thoughts on this? |
|
|
|
After merging your PR, Conbench analyzed the 2 benchmarking runs that have been run so far on merge-commit 4b55ea6. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 17 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…ache#47606) ### Rationale for this change The grpc-cpp conda package appears abandoned and is artificially pinning other dependencies to older versions (ex: orc). The more recent libgrpc conda package appears to be where the development is going forward ### What changes are included in this PR? Replaced grpc-cpp with libgrpc ### Are these changes tested? Yes ### Are there any user-facing changes? No * GitHub Issue: apache#46137 Authored-by: Will Ayd <william.ayd@icloud.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…ache#47606) ### Rationale for this change The grpc-cpp conda package appears abandoned and is artificially pinning other dependencies to older versions (ex: orc). The more recent libgrpc conda package appears to be where the development is going forward ### What changes are included in this PR? Replaced grpc-cpp with libgrpc ### Are these changes tested? Yes ### Are there any user-facing changes? No * GitHub Issue: apache#46137 Authored-by: Will Ayd <william.ayd@icloud.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Rationale for this change
The grpc-cpp conda package appears abandoned and is artificially pinning other dependencies to older versions (ex: orc). The more recent libgrpc conda package appears to be where the development is going forward
What changes are included in this PR?
Replaced grpc-cpp with libgrpc
Are these changes tested?
Yes
Are there any user-facing changes?
No