Skip to content

GH-46137: [C++] Replace grpc-cpp conda package with libgrpc - #47606

Merged
kou merged 1 commit into
apache:mainfrom
WillAyd:replace-grpc-cpp
Oct 6, 2025
Merged

kou merged 1 commit into
apache:mainfrom
WillAyd:replace-grpc-cpp

Conversation

@WillAyd

@WillAyd WillAyd commented Sep 19, 2025 •

Copy link
Copy Markdown
Contributor

Rationale for this change

The grpc-cpp conda package appears abandoned and is artificially pinning other dependencies to older versions (ex: orc). The more recent libgrpc conda package appears to be where the development is going forward

What changes are included in this PR?

Replaced grpc-cpp with libgrpc

Are these changes tested?

Yes

Are there any user-facing changes?

No

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #47605 has been automatically assigned in GitHub to PR creator.

Comment thread ci/conda_env_cpp.txt
libprotobuf
libutf8proc
lz4-c
make
meson
ninja
nodejs
orc
orc<2.1.0

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In CI orc is pinned to 1.9.0. This new pin is required due to some upstream bugs with the CMake configuration - see apache/orc#2408

@github-actions github-actions Bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Sep 19, 2025
@WillAyd

WillAyd commented Sep 19, 2025

Copy link
Copy Markdown
Contributor Author

The Go failure seems related although I'm not sure I can see anything in the logs that points to the issue. Maybe @zeroshade has an idea?

https://github.com/apache/arrow/actions/runs/17863409077/job/50799734977?pr=47606#step:13:1204

@h-vetinari

Copy link
Copy Markdown
Contributor

The grpc-cpp conda package appears abandoned and is artificially pinning other dependencies to older versions (ex: orc). The more recent libgrpc conda package appears to be where the development is going forward

Indeed the package was renamed (similar to the conda package for arrow going from arrow-cpp to libarrow) and we eventually dropped the compatibility wrapper for the old naming, which is why the last available builds will pull in very old dependencies.

@WillAyd

WillAyd commented Sep 27, 2025

Copy link
Copy Markdown
Contributor Author

It looks like the integration failure here was reported by @kou upstream in #47673

FWIW it has happened with every push so far on this branch, but maybe that has been bad luck

@WillAyd

WillAyd commented Oct 4, 2025

Copy link
Copy Markdown
Contributor Author

OK this is all green - @kou any thoughts on this?

@WillAyd WillAyd changed the title GH-47605: [C++] Replace grpc-cpp conda package with libgrpc GH-46137: [C++] Replace grpc-cpp conda package with libgrpc Oct 4, 2025
@github-actions

github-actions Bot commented Oct 4, 2025

Copy link
Copy Markdown

⚠️ GitHub issue #46137 has been automatically assigned in GitHub to PR creator.

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou
kou merged commit 4b55ea6 into apache:main Oct 6, 2025
31 checks passed
@kou kou removed the awaiting committer review Awaiting committer review label Oct 6, 2025
@github-actions github-actions Bot added the awaiting merge Awaiting merge label Oct 6, 2025
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 2 benchmarking runs that have been run so far on merge-commit 4b55ea6.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 17 possible false positives for unstable benchmarks that are known to sometimes produce them.

@WillAyd
WillAyd deleted the replace-grpc-cpp branch October 6, 2025 19:29
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this pull request Oct 15, 2025
…ache#47606)

### Rationale for this change

The grpc-cpp conda package appears abandoned and is artificially pinning other dependencies to older versions (ex: orc). The more recent libgrpc conda package appears to be where the development is going forward

### What changes are included in this PR?

Replaced grpc-cpp with libgrpc

### Are these changes tested?

Yes

### Are there any user-facing changes?

No

* GitHub Issue: apache#46137

Authored-by: Will Ayd <william.ayd@icloud.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Mottl pushed a commit to Mottl/arrow that referenced this pull request May 26, 2026
…ache#47606)

### Rationale for this change

The grpc-cpp conda package appears abandoned and is artificially pinning other dependencies to older versions (ex: orc). The more recent libgrpc conda package appears to be where the development is going forward

### What changes are included in this PR?

Replaced grpc-cpp with libgrpc

### Are these changes tested?

Yes

### Are there any user-facing changes?

No

* GitHub Issue: apache#46137

Authored-by: Will Ayd <william.ayd@icloud.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants