Repository navigation
GH-47441: [Python][Parquet] Allow passing write_time_adjusted_to_utc to Python's ParquetWriter - #47745
Conversation
|
|
|
|
2 similar comments
|
|
|
|
|
Hey @pitrou, I've exposed the UTC flag to the Python's Parquet API. |
pitrou
left a comment
There was a problem hiding this comment.
You'll need to update the docstrings as well (see _parquet_writer_arg_docs)
We can indeed write a simple end-to-end test. Showing that the data roundtrips is IMHO sufficient. |
Thanks! |
I don't think so, no. |
|
|
pitrou
left a comment
There was a problem hiding this comment.
LGTM, just one small suggestion
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit ed91f6f. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
…o_utc to Python's ParquetWriter (apache#47745) ### Rationale for this change Please see apache#47441 and apache#41476. The `ArrowWriterProperties.write_time_adjusted_to_utc` flag is available in C++, yet isn't accessible from Python. This PR introduces the said flag to Python API as well. ### What changes are included in this PR? Exposure of `use_time_adjusted_to_utc` boolean argument in Python's API. ### Are these changes tested? Yes, roundtrip parquet tests for all combinations of time types and their respective time units. ### Are there any user-facing changes? The users will be able to adjust the said flag directly from Python API. * GitHub Issue: apache#47441 Lead-authored-by: Bogdan Romenskii <rmnsk@seznam.cz> Co-authored-by: Antoine Pitrou <pitrou@free.fr> Signed-off-by: Antoine Pitrou <antoine@python.org>
…o_utc to Python's ParquetWriter (apache#47745) ### Rationale for this change Please see apache#47441 and apache#41476. The `ArrowWriterProperties.write_time_adjusted_to_utc` flag is available in C++, yet isn't accessible from Python. This PR introduces the said flag to Python API as well. ### What changes are included in this PR? Exposure of `use_time_adjusted_to_utc` boolean argument in Python's API. ### Are these changes tested? Yes, roundtrip parquet tests for all combinations of time types and their respective time units. ### Are there any user-facing changes? The users will be able to adjust the said flag directly from Python API. * GitHub Issue: apache#47441 Lead-authored-by: Bogdan Romenskii <rmnsk@seznam.cz> Co-authored-by: Antoine Pitrou <pitrou@free.fr> Signed-off-by: Antoine Pitrou <antoine@python.org>
Rationale for this change
Please see #47441 and #41476.
The
ArrowWriterProperties.write_time_adjusted_to_utcflag is available in C++, yet isn't accessible from Python. This PR introduces the said flag to Python API as well.What changes are included in this PR?
Exposure of
use_time_adjusted_to_utcboolean argument in Python's API.Are these changes tested?
Yes, roundtrip parquet tests for all combinations of time types and their respective time units.
Are there any user-facing changes?
The users will be able to adjust the said flag directly from Python API.
write_time_adjusted_to_utc#47441