Repository navigation

GH-50628: [C++][Parquet] Rework RecordReader to introduce flat optional optimization - #50629

Open

AntoinePrv wants to merge 62 commits into

apache:mainfrom

AntoinePrv:levels-bitmap

Commits on Oct 8, 2026
- Move TypedColReaderImpl::Skip
  AntoinePrv
  committed
  e17eec9
- Break TypedRecordReader inheritance on TypedColumnReader
  AntoinePrv
  committed
  feed609
- Add ReadValuesBuffer
  AntoinePrv
  committed
  202b354
- Split ColumnReaderImplBase definition and declaration
  AntoinePrv
  committed
  7829db2
- Add DefRepLevelsDecoder
  AntoinePrv
  committed
  63c56a8
- Explicit int32_t for LevelDecoder
  AntoinePrv
  committed
  46b395f
- Change ValuesBuffer API
  AntoinePrv
  committed
  f46f89a
- Add StackedLevelDecoder and prepare for modularity
  AntoinePrv
  committed
  2928a80
- Remove DefRepLevelsDecoder
  AntoinePrv
  committed
  7fe2381
- Split TypedRecordReader implementation
  AntoinePrv
  committed
  17ac56b
- First RequiredTypedRecordReader
  AntoinePrv
  committed
  7ce96cb
- Remove RecordReader protected members
  AntoinePrv
  committed
  b5f0424
- Fully use RequiredRecordReader
  AntoinePrv
  committed
  bb51e19
- Rename ReadValues -> ValueSink
  AntoinePrv
  committed
  79eb654
- Split ReserveValuesAndIsValid
  AntoinePrv
  committed
  22372da
- Devirtualize hooks with CRTP
  AntoinePrv
  committed
  f9dec99
- Simplify template
  AntoinePrv
  committed
  1d922a6
- Remove StackedLevelDecoder
  AntoinePrv
  committed
  463ad5d
- Remove mark_as_written
  AntoinePrv
  committed
  6d86e26
- Make some of ColumnReaderImplBase private
  AntoinePrv
  committed
  4823172
- Fix horrible dictionnary handling
  AntoinePrv
  committed
  931d075
- Simplify and rename ColumnChunkReader
  AntoinePrv
  committed
  3320b2b
- Add RleBitPackedToBitmapDecoder::CountUpTo
  AntoinePrv
  committed
  392b71a
- Add BitPackedToBitmapDecoder
  AntoinePrv
  committed
  343e0bf
- Add RleBitPackedToBitmapDecoder::Advance
  AntoinePrv
  committed
  0a2e3c1
- Add LevelToBitmapDecoder
  AntoinePrv
  committed
  af37312
- Add ValiditySinkBuffer
  AntoinePrv
  committed
  fadc841
- Auto reserve space in sinks:
  AntoinePrv
  committed
  2bf286f
- Fix integer types
  AntoinePrv
  committed
  f24efa1
- Nit in ColumnChunkReader
  AntoinePrv
  committed
  8043b45
- Eagerly read dict
  AntoinePrv
  committed
  2444c47
- Cleanups
  AntoinePrv
  committed
  a3cb538
- Add FlatOptionalTypedRecordReader
  AntoinePrv
  committed
  c297eed
- Add some doc
  AntoinePrv
  committed
  778c979
- Factorize ReadDictionary
  AntoinePrv
  committed
  ad6e524
- Simplify read_dense_for_nullable
  AntoinePrv
  committed
  f4ae4fc
- Factor Sinks with DataSinkBuffer
  AntoinePrv
  committed
  fe8bf3d
- Use LevelBufferSink in TypedRecordReader
  AntoinePrv
  committed
  cf7aa77
- Relax record reader level tests flat optional
  AntoinePrv
  committed
  056affa
- Fix compiler errrors
  AntoinePrv
  committed
  7e251a3
- Safe decoded number check and func rename
  AntoinePrv
  committed
  3e6eeb9
- Explicit values_written contract
  AntoinePrv
  committed
  f268787
- Fix LevelDecoder::max_level type
  AntoinePrv
  committed
  dbeaec0
- Fix integer convertion
  AntoinePrv
  committed
  f7c56ce
- Factorize level decoders
  AntoinePrv
  committed
  cca5726
- Fixt typos
  AntoinePrv
  committed
  c8b1c2a
- Move level decoder utility and rename file
  AntoinePrv
  committed
  6e4465f
- Move level decoder adapters to level_decoder.h
  AntoinePrv
  committed
  8089237
- Fix small typos
  AntoinePrv
  committed
  47e0874
- Fix issues in level counting
  AntoinePrv
  committed
  baba303
- Fix extra alloc
  AntoinePrv
  committed
  31d2007
- Add RecordReader::Make flag
  AntoinePrv
  committed
  9e3f8bc
- Throw on FlatOptional def_levels
  AntoinePrv
  committed
  07ee3c5
- Always call RecordReader with flat optiona optimization
  AntoinePrv
  committed
  02c9b2c
- Addition flat optional test
  AntoinePrv
  committed
  d833502
- Detemplate kdic
  AntoinePrv
  committed
  fda90cb
- Add flat optiona bse in flba and byte array
  AntoinePrv
  committed
  dbb7438
- Ad more flba and array test
  AntoinePrv
  committed
  1a205c8
- Make RecordReader::Make params struct public
  AntoinePrv
  committed
  5516651
- Run RecordReader tests with and without optimizations
  AntoinePrv
  committed
  d911101
- Rename flat_optiona_optimization as allow_levels_optimization
  AntoinePrv
  committed
  52e062c
- Add level optim option to RowGroupReader
  AntoinePrv
  committed
  74b3576

Commits

Commits on Oct 8, 2026