GH-50771: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_install_system_dependencies.sh

[hiroyuki-sato]

Rationale for this change

This is the sub issue #44748.

• SC2223: This default assignment may cause DoS due to globbing. Quote it.
• SC2006: Use $(...) notation instead of legacy backticked ....

shellcheck r_install_system_dependencies.sh
r_install_system_dependencies.sh: r_install_system_dependencies.sh: openBinaryFile: does not exist (No such file or directory)
palolovalley:arrow hsato$ shellcheck ci/scripts/r_install_system_dependencies.sh

In ci/scripts/r_install_system_dependencies.sh line 22:
: ${ARROW_SOURCE_HOME:=/arrow}
  ^--------------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/r_install_system_dependencies.sh line 25:
if [ "`which dnf`" ]; then
      ^---------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.

Did you mean:
if [ "$(which dnf)" ]; then


In ci/scripts/r_install_system_dependencies.sh line 27:
elif [ "`which yum`" ]; then
        ^---------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.

Did you mean:
elif [ "$(which yum)" ]; then


In ci/scripts/r_install_system_dependencies.sh line 29:
elif [ "`which zypper`" ]; then
        ^------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.

Did you mean:
elif [ "$(which zypper)" ]; then


In ci/scripts/r_install_system_dependencies.sh line 31:
elif [ "`which apk`" ]; then
        ^---------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.

Did you mean:
elif [ "$(which apk)" ]; then


In ci/scripts/r_install_system_dependencies.sh line 59:
  if [ "$ARROW_S3" == "ON" ] && [ -f "${ARROW_SOURCE_HOME}/ci/scripts/install_minio.sh" ] && [ "`which wget`" ]; then
                                                                                                ^----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.

Did you mean:
  if [ "$ARROW_S3" == "ON" ] && [ -f "${ARROW_SOURCE_HOME}/ci/scripts/install_minio.sh" ] && [ "$(which wget)" ]; then

For more information:
  https://www.shellcheck.net/wiki/SC2223 -- This default assignment may cause...
  https://www.shellcheck.net/wiki/SC2006 -- Use $(...) notation instead of le...

What changes are included in this PR?

• SC2006 Use $(...) notation instead of legacy backticks ...
• SC2223: Quote default variable assignments.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

• GitHub Issue: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_install_system_dependencies.sh #50771

[github-actions]

⚠️ GitHub issue #50771 has been automatically assigned in GitHub to PR creator.

[kou]

@github-actions crossbow submit -g r

[github-actions]

Revision: e45c988

Submitted crossbow builds: ursacomputing/crossbow @ actions-d4ec85d622

Task	Status
r-binary-packages
r-recheck-most
test-r-alpine-linux-cran
test-r-arrow-backwards-compatibility
test-r-depsource-system
test-r-dev-duckdb
test-r-devdocs
test-r-extra-packages
test-r-fedora-clang
test-r-gcc-11
test-r-gcc-12
test-r-install-local
test-r-install-local-minsizerel
test-r-linux-as-cran
test-r-linux-rchk
test-r-linux-sanitizers
test-r-linux-valgrind
test-r-m1-san
test-r-macos-as-cran
test-r-offline-maximal
test-r-ubuntu-22.04
test-r-versions
test-r-wasm

[conbench-apache-arrow]

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit dd41416.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.