Repository navigation
GH-51651: [C++][CI] Fix static linking for system Abseil and bundled GCS - #51653
Conversation
github-actions
Bot
added
Component: C++
awaiting committer review
tadeja
changed the title
|
@github-actions crossbow submit test-debian-13-cpp test-debian-experimental-cpp-gcc-15 |
|
|
@github-actions crossbow submit test-debian-13-cpp-* test-debian-experimental-cpp-gcc-15 |
|
Revision: d441634 Submitted crossbow builds: ursacomputing/crossbow @ actions-acf6d722bf
|
|
@github-actions crossbow submit test-ubuntu-22.04-cpp-bundled |
| # Bundled google-cloud-cpp needs system Abseil for static linking. | ||
| # Abseil .pc files include indirect link dependencies that base -labsl_* flags omit | ||
| find_package(PkgConfig QUIET) | ||
| if(PkgConfig_FOUND) |
There was a problem hiding this comment.
should we add an output message if not?
github-actions
Bot
added
awaiting changes
|
Revision: d441634 Submitted crossbow builds: ursacomputing/crossbow @ actions-21d737ae20
|
github-actions
Bot
added
awaiting change review
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The CMake and pkg-config dependency exports consistently address the reported static-link failures.
Review effort: Balanced
Findings: None
What changed in this PR
Exports system Abseil dependencies needed by static Arrow builds using bundled GCS.
Changes:
- Adds Abseil targets to Arrow’s static CMake interface.
- Adds matching dependencies to static pkg-config metadata.
| File | Description |
|---|---|
cpp/src/arrow/CMakeLists.txt |
Exports required Abseil CMake targets. |
cpp/cmake_modules/ThirdpartyToolchain.cmake |
Adds available Abseil packages to arrow.pc. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
tadeja
changed the title
|
@github-actions crossbow submit example-cpp-minimal-build-static* |
|
Revision: 207fb17 Submitted crossbow builds: ursacomputing/crossbow @ actions-2d4ac1008a
|
github-actions
Bot
added
awaiting merge
Rationale for this change
Static Arrow linking can fail for bundled GCS and system Abseil.
What changes are included in this PR?
Export Abseil dependencies via CMake target and pkg-config metadata.
Are these changes tested?
To be additionally verified by CI.
Are there any user-facing changes?
This improves downstream static linking.
Was AI used for this PR?
PR code and description written by:
Reviewed before submission by: