Repository navigation
Conversation
|
Thanks for opening a pull request! This pull request has been automatically closed because you currently have 4 open pull requests, which is more than the limit of 3. Due to the increase in pull requests opened by AI bots, and in order to keep the review queue manageable, Apache Arrow limits contributors without repository access to at most 3 concurrently open pull requests. This helps make sure each pull request gets the attention it needs and that work in progress does not go stale. Once one of your other open pull requests has been merged or closed, you are welcome to reopen this one. See also: |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fixes #53138. R users cannot enable Parquet page-checksum verification even though C++ already supports it. The corrupt-checksum fixtures therefore read successfully, with no R option to detect the mismatched CRCs.
What changes are included in this PR?
ParquetReaderProperties, forwarding to the existing C++ option, and regenerate the binding registration code.read_parquet().The changes are split into three focused commits: bindings, regression tests, and documentation.
Are these changes tested?
CRC checksum verification failed.test-parquet.Rselection passes 114 assertions with no failures or errors; two existing CRAN-skipped tests are skipped.Validation used R 4.3.3, Arrow R 25.0.1.9000, and Arrow C++ 26.0.0-SNAPSHOT.
Are there any user-facing changes?
R users can opt in with:
Verification remains disabled by default. When enabled, existing page checksums are checked; files without page checksums remain readable.
Was AI used for this PR?
Codex assisted with the investigation, implementation, regression tests, documentation, validation, and PR description, and reviewed the changes before submission.
PR code and description written by:
Reviewed before submission by: