ATLAS-5188: Remove jsp-api jar dependency #497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinal-shah
reviewed
Jan 16, 2026
| </manifest> | ||
| </archive> | ||
| <packagingExcludes>WEB-INF/lib/dom4j-*.jar,${packages.to.exclude}</packagingExcludes> | ||
| <packagingExcludes>WEB-INF/lib/dom4j-*.jar,WEB-INF/lib/jsp-api*.jar,${packages.to.exclude}</packagingExcludes> |
Collaborator
There was a problem hiding this comment.
is it still required to exclude?
Contributor
Author
There was a problem hiding this comment.
Yes, it is required because jsp-api jar still gets transitively included from hadoop-common dependency.
We can explicitly exclude from hadoop-common, but I would still keep this exclude, so that if any other dependency pulls jsp-api, then it doesn't gets bundled in final war file.
pinal-shah
approved these changes
Jan 16, 2026
pinal-shah
pushed a commit
that referenced
this pull request
Jan 16, 2026
(cherry picked from commit 928a378)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Removed jsp-api jar file dependency from webapp and main pom. If the jsp-api jar gets pulled from any other dependency transitively, then excluding it from getting packaged in the war file.
How was this patch tested?