Skip to content

Fix INT64_MIN block_count DoS in C SDK #4034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kalt2212 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix INT64_MIN block_count DoS in C SDK #4034

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions lang/c/src/value-read.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,11 @@ read_array_value(avro_reader_t reader, avro_value_t *dest)

while (block_count != 0) {
if (block_count < 0) {
block_count = block_count * -1;
if (block_count == INT64_MIN) {
avro_set_error("Invalid array block count");
return EINVAL;
}
block_count = -block_count;
check_prefix(rval, avro_binary_encoding.
read_long(reader, &block_size),
"Cannot read array block size: ");
Expand Down Expand Up @@ -89,7 +93,11 @@ read_map_value(avro_reader_t reader, avro_value_t *dest)

while (block_count != 0) {
if (block_count < 0) {
block_count = block_count * -1;
if (block_count == INT64_MIN) {
avro_set_error("Invalid map block count");
return EINVAL;
}
block_count = -block_count;
check_prefix(rval, avro_binary_encoding.
read_long(reader, &block_size),
"Cannot read map block size: ");
Expand Down
Loading