-
Notifications
You must be signed in to change notification settings - Fork 4.5k
remove website, typescript, etc - pubsublite uses #37412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
remove website, typescript, etc - pubsublite uses #37412
Conversation
Summary of ChangesHello @derrickaw, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request finalizes the removal of Google Cloud Pub/Sub Lite integration across the Apache Beam project. It systematically eliminates all associated code, dependencies, and documentation from various SDKs and project components, ensuring a thorough and clean deprecation of this connector. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Playground Frontend Test failure I think is due to a version issue with Flutter and its dependencies and not related to this PR. Similar thing happened on a recent related PR - #37383 (comment) |
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
4a7251c to
2b9fe58
Compare
… but add a slight improvement
ahmedabu98
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not very confident about the changes in website/Dockerfile, can you explain why those changes are necessary?
The rest LGTM
I had noticed in some of the error logs that an older pip install was being used and was trying to improve on it and a recent PR also updated yarn to a particular version and wanted to automate that away, but in reality these improvements should go in another PR. Sorry about that. Thanks. Side note, a few of these changes were to generated files that I shouldn't have touched and were was kicking off some tests that were perma-red like you mentioned in another PR. I have removed those file changes from this PR. |
|
Assigning reviewers: R: @damccorm for label website. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Abacn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this clean up!
| LOCATION 'projects/testing-integration/topics/user-location' | ||
| ``` | ||
|
|
||
| ## Pub/Sub Lite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
website change becomes effective next day. We can remove website contents after new Beam release drops PubsubLite release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gotcha, removed the changes, thanks
#37375 - part 4 of deprecating pubsublite
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.