Upgrade Spanner to the latest version #37433
Conversation
Summary of ChangesHello @sakthivelmanii, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the dependency management for Google Cloud Spanner within the project's Gradle build system. Instead of explicitly declaring and pinning the Spanner version, the changes delegate this responsibility to the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
sakthivelmanii
force-pushed
the
master
branch
2 times, most recently
from
b36d8fc to
636fccc
Compare
sakthivelmanii
force-pushed
the
master
branch
from
636fccc to
789e4f4
Compare
...io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerConfig.java
Outdated
Show resolved
Hide resolved
.../google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java
Outdated
Show resolved
Hide resolved
...gle-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessorTest.java
Outdated
Show resolved
Hide resolved
sakthivelmanii
force-pushed
the
master
branch
2 times, most recently
from
a35fe73 to
dc8a042
Compare
sakthivelmanii
force-pushed
the
master
branch
from
dc8a042 to
b930c89
Compare
| } | ||
| SpannerAccessor sa = SpannerAccessor.getOrCreate(spannerConfigWithCredential); | ||
| DatabaseClient databaseClient = sa.getDatabaseClient(); | ||
| return databaseClient.getDialect(); |
There was a problem hiding this comment.
Is there a reason to undo this change? It seems like it is still probably better to force the SpannerAccessor class to close
| def google_cloud_bigdataoss_version = "2.2.26" | ||
| // [bomupgrader] determined by: com.google.cloud:google-cloud-spanner, consistent with: google_cloud_platform_libraries_bom | ||
| def google_cloud_spanner_version = "6.104.0" | ||
| def google_cloud_spanner_version = "6.107.0" |
There was a problem hiding this comment.
Do we need this version to be tracked at all now or can we remove this line?
| SpannerOptions.Builder builder = SpannerOptions.newBuilder(); | ||
|
|
||
| // Disable gRPC gcp extension which was causing the application thread to stall. | ||
| builder.disableGrpcGcpExtension(); |
There was a problem hiding this comment.
Is the root cause known/is there a timeline for us to remove this? If so, could you please file a Beam issue tracking the fix and reference it in a TODO here?
| .map(ValueProvider::get) | ||
| .orElse(DEFAULT_SESSION_WAIT_DURATION); | ||
| builder.setSessionPoolOption( | ||
| SessionPoolOptions.newBuilder().setWaitForMinSessionsDuration(waitDuration).build()); |
There was a problem hiding this comment.
Is this change related to the hangs?
3 participants
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.