fix: docker-compose, volumes don't overwrite UI#3205
Merged
Conversation
currently, mounting all of the working directory to the app dir in the container means that the UI built in the container at `/usr/src/app/plugins/magma` is overwritten by what is on the host. If the UI is not built on the host, the container and docker-compose will not work as expected. This change adds a volume to protect the contents of the built UI in the container from being overwritten by the host's content in `/usr/src/app/plugins/magma`
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a Docker Compose issue where the host directory mount was overwriting the pre-built UI components in the container. The solution adds a named volume to protect the built UI directory from being overwritten by the host mount.
- Adds a container name for better identification
- Protects the pre-built UI directory from host mount overwrites
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
@deacon-mp one copilot suggestion accepted. Let me know if you need these commits squashed. |
deacon-mp
approved these changes
Oct 6, 2025
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
currently, mounting all of the working directory to the app dir in the container means that the UI built in the container at
/usr/src/app/plugins/magmais overwritten by what is on the host. If the UI is not built on the host, the container and docker-compose will not work as expected.This change adds a volume to protect the contents of the built UI in the container from being overwritten by the host's content in
/usr/src/app/plugins/magmaType of change
How Has This Been Tested?
browse UI, works
Checklist: