ignore fact creation timestamp comparison in scheduling unit test#3215
Merged
Conversation
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a race condition in a scheduling unit test where fact creation timestamps could differ by 1 second from expected values, causing intermittent test failures. The fix uses a mock placeholder to ignore timestamp comparisons since the creation date is not part of the test criteria.
- Replaces specific timestamp expectations with
mock.ANYfor fact creation dates - Prevents race condition failures in test assertions
- Maintains test integrity by only ignoring non-essential timestamp data
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
deacon-mp
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
tests/api/v2/handlers/test_schedules_api.py:183would often fail due to a race condition where a fact creation date would be off by 1 second from the expected value. This fix replaces the expected creation date with a mock placeholder catch-all to avoid this issue, since the fact creation date is not part of the unit test criteria.Type of change
How Has This Been Tested?
Ran test via workflow
Checklist: