Skip to content

don't override coverage path for sonar#3216

Merged
uruwhy merged 2 commits into
masterfrom
VIRTS-5001
Oct 14, 2025
Merged

don't override coverage path for sonar#3216
uruwhy merged 2 commits into
masterfrom
VIRTS-5001

Conversation

@uruwhy
Copy link
Copy Markdown
Contributor

@uruwhy uruwhy commented Oct 14, 2025

Description

  • Fix workflow issue where sonarcloud could not parse coverage file due to invalid paths in it

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Verified error no longer appears in workflow

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@uruwhy uruwhy requested a review from deacon-mp October 14, 2025 15:11
@deacon-mp deacon-mp requested a review from Copilot October 14, 2025 15:37
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a workflow issue where SonarCloud was unable to parse coverage files due to invalid paths. The fix removes a path override step that was causing incorrect source paths in the coverage XML file.

  • Removes the "Override Coverage Source Path for Sonar" workflow step
  • Eliminates sed command that was modifying coverage.xml paths incorrectly
  • Allows SonarCloud to properly parse coverage files with correct paths

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sonarqubecloud
Copy link
Copy Markdown

@uruwhy uruwhy merged commit 0ff0bff into master Oct 14, 2025
13 checks passed
@uruwhy uruwhy deleted the VIRTS-5001 branch October 14, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants