Addressing some unit test warnings

[uruwhy]

Description

• properly close FTP and TCP contacts to address associated warnings in unit tests
• make FTP unit tests able to remove non-empty FTP directory, and use test directory name (fixes edge case where FTP unit test fails when users have previously used the FTP contact)
• set the pyasn1 version to 0.5.x to address pyasn1-related warnings in unit tests
• remove event_loop fixtures in unit tests to address related warnings
• update mock return setup in data svc test to address warnings
• update some schemas to remove deprecated ordered option in Meta subclass

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Ran unit tests locally
Ran manx agent with TCP contact to verify functionality still intact, verified server closed with dead and live manx sessions
Ran sandcat agent with FTP contact to verify functionality still intact

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works

[sonarqubecloud]

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[sonarqubecloud]

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[Copilot]

Pull request overview

This PR addresses various unit test warnings by improving resource cleanup, updating test fixtures, and pinning dependency versions.

• Properly implements cleanup logic for TCP and FTP contacts to prevent resource warnings
• Updates mock setup for async methods and removes deprecated event_loop fixture usage
• Improves FTP test robustness with better directory handling

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
app/contacts/contact_tcp.py	Adds proper cleanup methods with task cancellation and session closure handling for TCP contact server
app/contacts/contact_ftp.py	Simplifies FTP server startup by removing Python version-specific code paths and adds stop method
tests/contacts/test_contact_ftp.py	Uses test-specific directory name and shutil.rmtree for non-empty directory cleanup
tests/services/test_data_svc.py	Updates async mock setup to use return_value=None instead of async_mock_return helper
tests/conftest.py	Removes deprecated event_loop fixture parameter from async fixtures
tests/api/v2/test_knowledge.py	Removes deprecated event_loop fixture parameter from async fixture
requirements.txt	Pins pyasn1 to version 0.5.x to address related warnings

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[clenk]

LGTM, thank you!

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
86.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud