Skip to content

Update server to launch without magma plugin#3255

Merged
clenk merged 4 commits into
apache:masterfrom
kmpepper:magma-dependencies-2
Feb 26, 2026
Merged

Update server to launch without magma plugin#3255
clenk merged 4 commits into
apache:masterfrom
kmpepper:magma-dependencies-2

Conversation

@kmpepper
Copy link
Copy Markdown
Contributor

Description

  • follow up to decoupling caldera core with magma plugin dependencies, updating server.py to still launch with --build flag even when magma plugin is not present

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • unit tests
  • server run with --build flag & no magma dir, with --uidev flag and no magma

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Copy link
Copy Markdown
Contributor

@clenk clenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For each of the build warnings, there's two different cases that could cause them. One is if plugins/magma doesn't exist (the plugin wasn't cloned, repo wasn't cloned recursively). The other is if plugins/maga/dist doesn't exist (npm build was never run). Do you think we should separate out those two different cases each with their own warning?

@kmpepper kmpepper requested a review from clenk February 23, 2026 19:39
Comment thread server.py Outdated
@kmpepper kmpepper requested a review from clenk February 25, 2026 22:22
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@clenk clenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@clenk clenk merged commit 62a41f8 into apache:master Feb 26, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants