-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix(deps): upgrade aioftp from ~=0.20.0 to ==0.27.2 #3333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
54cd60c
fix(deps): upgrade aioftp from ~=0.20.0 to ==0.27.2
deacon-mp fae2e52
fix: address Copilot review feedback
deacon-mp 91acc7d
Add callable() check for aioftp.worker and remove unused imports
deacon-mp a77312b
Merge branch 'master' into fix/aioftp-version-pin
jlklos 45fda51
Update test to use expected_type
jlklos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| """Test that aioftp meets the minimum required version (>= 0.21.0) to avoid | ||
| the vulnerability flagged in aioftp ~= 0.20.0 by the safety DB.""" | ||
| import importlib.metadata | ||
|
|
||
| from packaging.version import Version | ||
|
|
||
|
|
||
| def test_aioftp_version_meets_minimum(): | ||
| """aioftp must be >= 0.21.0 to avoid CVE / safety-DB advisory for 0.20.x.""" | ||
| version_str = importlib.metadata.version("aioftp") | ||
| assert Version(version_str) >= Version("0.21.0"), ( | ||
| f"aioftp {version_str} is below the minimum required 0.21.0; " | ||
| "upgrade to 0.27.2 or later." | ||
| ) | ||
|
|
||
|
|
||
| def test_aioftp_server_api_intact(): | ||
| """Ensure the server-side API surface used by contact_ftp is available.""" | ||
| import aioftp | ||
|
|
||
| expected_classes = { | ||
| "Server": type, | ||
| "User": type, | ||
| "Permission": type, | ||
| "ConnectionConditions": type, | ||
| "PathPermissions": type, | ||
| } | ||
| for name, expected_type in expected_classes.items(): | ||
| obj = getattr(aioftp, name, None) | ||
| assert obj is not None, f"aioftp missing expected attribute: {name}" | ||
| assert isinstance(obj, expected_type), ( | ||
| f"aioftp.{name} should be a class, got {type(obj)!r}" | ||
| ) | ||
|
|
||
| # worker may be a function or coroutine function rather than a class | ||
| assert hasattr(aioftp, "worker"), "aioftp missing expected attribute: worker" | ||
| assert callable(aioftp.worker), ( | ||
| f"aioftp.worker should be callable, got {type(aioftp.worker)!r}" | ||
| ) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.