Skip to content

fix: --fresh fails to clean cookie_storage, auth_svc crashes on key mismatch #3355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
uruwhy merged 5 commits into from
Apr 14, 2026
+2 −1
Merged

fix: --fresh fails to clean cookie_storage, auth_svc crashes on key mismatch #3355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9f04f13
fix: --fresh fails to clean cookie_storage, auth_svc crashes on key m…
Apr 3, 2026
0c4c992
corrected tests to look for exact filepath in DATA_FILE_GLOBS
Apr 10, 2026
277cc66
reverting changes to auth_svc and file_svc, deleting test_fresh_clean…
Apr 13, 2026
19dbe35
Merge branch 'master' into fix/fresh-cookie-cleanup
fionamccrae Apr 13, 2026
45d0589
revert file_svc
uruwhy Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/service/auth_svc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
except (ValueError, TypeError):
max_age = None
try:
if os.path.exists(os.path.join('data', cookie_file)):
if os.path.exists(cookie_path):
secret_key = file_svc._read(cookie_path)
self.log.debug('Loaded persistent session key from data/cookie_storage')
else:
Expand Down Expand Up @@ -190,7 +190,7 @@
except (HTTPUnauthorized, HTTPForbidden):
return await self.login_redirect(request, use_template=False)

async def get_permissions(self, request):

Check failure on line 193 in app/service/auth_svc.py

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Refactor this function to always return tuples of the same length. 


See more on https://sonarcloud.io/project/issues?id=mitre_caldera&issues=AZ2I2yaFRIAoJb6q5s4V&open=AZ2I2yaFRIAoJb6q5s4V&pullRequest=3355
identity_policy = request.config_dict.get('aiohttp_security_identity_policy')
identity = await identity_policy.identify(request)
if identity in self.user_map:
Expand Down
1 change: 1 addition & 0 deletions app/service/data_svc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
'data/results/*',
'data/sources/*',
'data/object_store',
'data/cookie_storage',
)

PAYLOADS_CONFIG_STANDARD_KEY = 'standard_payloads'
Expand Down
Loading