CAMEL-23300: pass connectionString to couchbase-sink connector#1761
Merged
Conversation
Expose the connectionString endpoint option so the Couchbase SDK connects to the correct KV port when Testcontainers maps ports randomly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
connectionStringendpoint option in the couchbase-sink kamelet and connector configservice.getConnectionString()in the integration test so the Couchbase SDK connects to the correct randomly-mapped KV portDepends on apache/camel-kamelets#2792 for the upstream kamelet catalog update.
Test plan
CamelSinkCouchbaseITCase.testBasicSendReceivepasses locally with Couchbase 8.0.0 container and random port mapping