ci: fix security-model.adoc Antora build + relative-link errors#2836
Merged
oscerd merged 1 commit intoMay 15, 2026
Merged
Conversation
The Kamelet Catalog security model page (added in apache#2835, issue apache#2834) uses Kamelet property-placeholder syntax {{property}} and Camel simple syntax ${body} as literal text in inline prose and tables. Asciidoctor parses the inner {property} / {body} as attribute references, cannot resolve them, and emits 'skipping reference to missing attribute' warnings. camel-website's strict production Antora build (build:antora-perf) aggregates this page from apache/camel-kamelets main and fails on those warnings, which turns every camel-website pull request red regardless of its content. Escape the inner attribute reference with a backslash ({\{property}}, $\{body}); Asciidoctor consumes the backslash and renders the literal {{property}} / ${body} unchanged, with no attribute resolution and no warning. Documentation-only change; no rendered-output difference. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
oscerd
changed the title
This was referenced May 15, 2026
oscerd
added a commit
that referenced
this pull request
May 16, 2026
Follow-up to #2836. That PR was squash-merged with only its first commit (placeholder escaping); the relative-link commit was pushed afterwards and never merged, so camel-kamelets main still carries 4 absolute https://camel.apache.org/... links. They are now the sole remaining camel/relative-links failure in the camel-website check:html step (4 errors in camel-kamelets/next/security-model.html), keeping every camel-website PR red. Convert the 4 in-site links to root-relative link: macros (link:/security/, link:/manual/security-model.html), matching apache/camel core security-model.adoc (apache/camel#23224) and the sibling subproject fixes (apache/camel-kafka-connector#1774, apache/camel-quarkus#8661). The merged placeholder escaping is left intact; private-security@camel.apache.org email references are unchanged. Documentation-only; same link targets, rendered relative. Signed-off-by: Andrea Cosentino <ancosen@gmail.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI Fix
Two independent camel-website CI failures, both rooted in this single page
docs/modules/ROOT/pages/security-model.adoc(added in #2835 / issue #2834).Neither is caused by the camel-website PR that surfaced them — they break
every camel-website pull request.
Failed runs (camel-website): https://github.com/apache/camel-website/actions/runs/25926572539
1.
build:antora-perf— Asciidoctor missing-attribute warnings{{property}}/${body}placeholder text is parsed by Asciidoctor asattribute references (
skipping reference to missing attribute: property×22,body×1). The strict production Antora build fails on these.Fix: backslash-escape the inner reference (
{\{property}},$\{body}) —canonical Asciidoctor idiom, renders unchanged, no warning.
2.
check:html—camel/relative-linksviolationsThe page used absolute
https://camel.apache.org/...URLs (4 errors). Thecamel-website linter requires in-site links to be relative.
Fix: convert to root-relative
link:/security/andlink:/manual/security-model.html, matching apache/camel core security-model.adoc(fixed identically in apache/camel#23224).
private-security@camel.apache.orgemail references intentionally left unchanged.
Documentation-only; no rendered-output change. Verified statically (no
Asciidoctor/Antora CLI in the environment); the camel-website Antora build is
the definitive check.
Deferred Issues
None — both root causes fixed inline. Sibling per-subproject security models
have the same relative-link issue and are fixed in companion PRs
(camel-kafka-connector, camel-quarkus, camel-karaf).
Claude Code on behalf of Andrea Cosentino