Skip to content

Conversation

@pnoltes
Copy link
Contributor

@pnoltes pnoltes commented Feb 10, 2026

This PR removes the usage of 'jar' to create bundle zips.

'jar' was used to ensure that the 'MANIFEST.mf' was the first entry in a zip file, which can be relevant when streaming bundles to a deployment. This was briefly relevant when combining Apache Celix with the (now retired) Apache Ace project. Because the 'MANIFEST.mf' file is now a 'MANIFEST.json' file, 'jar' is no longer needed.

With this PR, creating bundles can be done by using the CMake built-in zip support (default) or - when disabling compression - with the 'zip' executable.

I also briefly looked at replacing zip with something like Zstandard, but I think this introduces too much complexity without much gain.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.49%. Comparing base (a0562f8) to head (cf0bd6b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #833      +/-   ##
==========================================
- Coverage   91.50%   91.49%   -0.02%     
==========================================
  Files         235      235              
  Lines       28686    28686              
==========================================
- Hits        26248    26245       -3     
- Misses       2438     2441       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@PengZheng PengZheng self-requested a review February 11, 2026 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants