Fix snapshot physical size listing

[JoaoJandre]

Description

This PR fixes the snapshot physical size listing. Since #7873, the snapshot physical size has only been fetched from the secondary storage. This has two issues:

1. It is possible for the snapshot to be on the primary storage, and thus these snapshots always return size 0.
2. Up until KVM incremental snapshot feature #9270, at least in KVM, every snapshot that was copied to secondary storage also had a reference to the primary storage. As the SnapshotObject has the ID for the primary storage reference, when searching for the reference to get the size, we search for a reference that is in the storage with role Image, but the ID of a primary storage; thus, no reference is returned.

This PR fixes this behavior. Fixes #11442

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Using KVM, created two volume snapshots, one on secondary storage and one on primary storage. Verified that in version 4.20.1 both returned 0 for physical size. After applying this patch, both return what is stored in the DB for their respective physical sizes.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.17%. Comparing base (f5b4858) to head (6110eef).
⚠️ Report is 4 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...he/cloudstack/storage/snapshot/SnapshotObject.java	0.00%	7 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20   #11448      +/-   ##
============================================
- Coverage     16.17%   16.17%   -0.01%     
  Complexity    13284    13284              
============================================
  Files          5656     5656              
  Lines        497990   497995       +5     
  Branches      60399    60400       +1     
============================================
  Hits          80529    80529              
- Misses       408499   408504       +5     
  Partials       8962     8962              

Flag	Coverage Δ
uitests	4.00% <ø> (ø)
unittests	17.02% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sureshanaparti]

@blueorangutan package

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 14628

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14633

[RosiKyu]

LGTM - tested and verified the fix

• CloudStack’s API/UI is now correctly picking up the Image ref’s physical_size after the fix

[sureshanaparti]

clgtm