Enable UEFI on KVM hosts (by default), and configure with some default settings#11740
Conversation
|
@blueorangutan package |
There was a problem hiding this comment.
Pull Request Overview
Enables UEFI support on KVM hosts by default with appropriate configuration settings across multiple system components.
- Adds UEFI configuration properties for legacy and secure boot modes with OVMF firmware paths
- Integrates UEFI properties files into system VM agents and console proxy components
- Updates packaging dependencies to include required OVMF and swtpm packages
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| agent/conf/uefi.properties.in | Defines UEFI configuration properties with template placeholders for firmware paths |
| packaging/el8/replace.properties | Sets OVMF firmware file paths for CentOS/RHEL 8 systems |
| packaging/debian/replace.properties | Sets OVMF firmware file paths for Debian-based systems |
| packaging/el8/cloud.spec | Adds edk2-ovmf and swtpm package dependencies for RPM builds |
| debian/control | Adds ovmf and swtpm package dependencies for Debian builds |
| pom.xml | Excludes uefi.properties from license header checks |
| systemvm/systemvm-agent-descriptor.xml | Includes uefi.properties in system VM agent configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## 4.22 #11740 +/- ##
=============================================
- Coverage 17.56% 3.58% -13.99%
=============================================
Files 5909 445 -5464
Lines 529059 37534 -491525
Branches 64617 6901 -57716
=============================================
- Hits 92941 1346 -91595
+ Misses 425664 36024 -389640
+ Partials 10454 164 -10290
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15193 |
weizhouapache
left a comment
There was a problem hiding this comment.
code lgtm
checked the settings on ol8 and u24
|
Hey @sureshanaparti , I am having problem with Snapshots of Windows guest instances because they require UEFI. Apparently, Have you consider this condition? |
will check it @daviftorres |
b352909 to
ff29741
Compare
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15298 |
@daviftorres btw: the issue does not block this PR as this only changes the KVM host setting, not vm settings |
|
@sureshanaparti , ready to merge? |
not yet @DaanHoogland , will update you. |
ff29741 to
6847c0d
Compare
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 15463 |
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
f3a46de to
4a752ad
Compare
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15528 |
|
@sureshanaparti |
@weizhouapache doc PR here: apache/cloudstack-documentation#589 |
4a752ad to
1090d3f
Compare
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 15651 |
|
@blueorangutan package |
|
@rosi-shapeblue a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15659 |



Description
This PR enables UEFI on KVM hosts (by default), and configure with some default settings.
and updates the logs while listing host for migration of a UEFI enabled VM (fixes #11963).
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Verified the UEFI packages and settings at /etc/cloudstack/agent/uefi.properties in ol8/ol9/debian12.
KVM Host / Agent (OL8):
MS (OL8):
KVM Host / Agent (Debian12):
MS (Debian12):
How did you try to break this feature and the system with this change?