Add cloud image downloader script#11918
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11918 +/- ##
============================================
- Coverage 17.85% 17.85% -0.01%
+ Complexity 15998 15997 -1
============================================
Files 5930 5930
Lines 531441 531441
Branches 64973 64973
============================================
- Hits 94890 94879 -11
- Misses 425924 425937 +13
+ Partials 10627 10625 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c3c8725 to
6a98dd4
Compare
DaanHoogland
left a comment
There was a problem hiding this comment.
tested manually in production 😶🌫️ and clgtm
|
Thank you @shwstppr for your review, resolved the last comment as well. PR is ready for merge. |
shwstppr
left a comment
There was a problem hiding this comment.
Minor re-ordering, then maybe we can merge
|
Thank you @shwstppr for the suggestion, pr is updated. Reordered the keys by distro version and keeing x86_64 first. |
39912df to
656b99b
Compare
Co-authored-by: dahn <daan.hoogland@gmail.com>
Co-authored-by: dahn <daan.hoogland@gmail.com>
a9e6347 to
3e7994a
Compare
|
@blueorangutan package |
|
We just reordered the keys, it should be fine to merge. However its better to verify the changes, I will quickly test and update the results. |
|
@DaanHoogland tested the script, it works without any issue. |
Description
This PR adds cloud image downloader script. It will be setup as cron job to periodically refresh cloud images located at https://download.cloudstack.org/templates/cloud-images.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?